Jump to content

Template talk:Infobox NFL biography

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Dark mode compatibility

[edit]

Could this infobox (and other similar ones) be updated to properly support the non-gadget dark mode option on the Vector 2022 skin? The Module:Gridiron color/data it is drawing from works on the mobile app and is shown as intended as seen here, so it seems to be an issue specific to being embedded within templates. This resource seems like it would be of help.

Additionally, could the secondary color at the bottom of the infobox be hidden when no PFR links are included as seen on here? I can provide screenshots if needed. Thanks in advance for any efforts in getting these fixed. ~ Dissident93 (talk) 15:55, 29 July 2024 (UTC)[reply]

Edit request 4 September 2024

[edit]

Please lowercase the display of CFL Draft to CFL draft to match the main article (CFL draft). Diff of suggested changes. Also, please see the CFL draft RM as evidence of consensus. ~WikiOriginal-9~ (talk) 02:47, 4 September 2024 (UTC)[reply]

Done.—Bagumba (talk) 05:48, 4 September 2024 (UTC)[reply]

Template-protected edit request on 8 September 2024

[edit]

Lowercase Round: and Pick:, which are non-initial in draft line:

change / Round: to / round: – 5 places
change / Pick: to / pick: – 4 places Dicklyon (talk) 04:26, 8 September 2024 (UTC)[reply]
 Completed. P.I. Ellsworth , ed. put'er there 10:14, 8 September 2024 (UTC)[reply]

Offseason and practice squad linking

[edit]

When you click that link, the article says the offseason is before preseason and conditioning. The asterisk includes preseason and training camp so not 100% sure it should actually be explicity linked like that. Linking practice squad also breaks up the gray text that serves as a sort of italics. Now it all meshes together with the team list. ~WikiOriginal-9~ (talk) 22:24, 14 October 2024 (UTC)[reply]

The idea was to link to terms that lacked them since they are rarely explained in the article itself. I reverted it, but still think it could work if there's a dedicated NFL offseason section we could link to and perhaps move its location to avoid the MOS:SEAOFBLUE issue. ~ Dissident93 (talk) 23:03, 14 October 2024 (UTC)[reply]

PFR error

[edit]

See the infobox at Rudy Bukich. Not sure what's causing it, maybe the military section? ~WikiOriginal-9~ (talk) 01:44, 15 October 2024 (UTC)[reply]

I added |module=, which at least fixed the mangled url display issue. But the football player stats link now shows up after the military info, not before. Maybe Frietjes would have some insight? —Bagumba (talk) 02:26, 15 October 2024 (UTC)[reply]
It's always going to show at the bottom since it's using the |below= parameter. I was testing a new arrangement earlier that included the links below their relevant sections rather than all grouped at the bottom, which would fix the issue. ~ Dissident93 (talk) 02:57, 15 October 2024 (UTC)[reply]
It's live now. Dan Campbell's article is a good example of the change. ~ Dissident93 (talk) 03:50, 15 October 2024 (UTC)[reply]
Assuming space is no longer an issue, can we expand "PFR" back to pro-football-reference.com or Pro Football Reference. Seems space was an issue when we needed to have "Player" and "Coaching" labels when the links were comingled.[1] I mean AmF experts might know, and WP editors know, but a casual fan might not, and certainly not a non-fan.—Bagumba (talk) 04:22, 15 October 2024 (UTC)[reply]
What was the rationale to change from "Stats at" wording to "profile" for the links?[2] It's only a minor point for "consistency", but {{Infobox basketball biography}} is also using the "Stats at" format. But I guess we can make it consistent, if there's a buy-in on the reasoning. —Bagumba (talk) 04:29, 15 October 2024 (UTC)[reply]
I do prefer "Stats at", but I also wanted to say that I'm a fan of the stats links being moved to relevant sections. Hey man im josh (talk) 12:27, 15 October 2024 (UTC)[reply]
I support the change, but I also prefer "Stats at" like Hey man im josh. This language made it clear that this is providing a source for the stats in the infobox. This is important, because in most NFL bios, there isn't a stat table in the body of the text that can be reference. See Wuert Engelmann for example. Dissident93 can we add that back in? « Gonzo fan2007 (talk) @ 14:43, 15 October 2024 (UTC)[reply]
Actually, this is causing more unintended problems. If there are no stats added to the infobox, then the PFR link doesn't show up at all. Dissident93, I am going to revert to a clean version. Can you build the new template in the sandbox and make sure everything works, gain some consensus on the changes and then reimplement? « Gonzo fan2007 (talk) @ 14:45, 15 October 2024 (UTC)[reply]
Yes, the testcases at Template:Infobox_NFL_biography/testcases#Renaldo_Nehemiah_(former_player_and_coach) and Template:Infobox_NFL_biography/testcases#Chris_Sailer_(former_Arena_Football_League_player,_no_number) show this. The question would be if someone was in multiple leagues, but there's not stats supplied for some of those leagues, where would the respective leagues' stats link go?—Bagumba (talk) 15:59, 15 October 2024 (UTC)[reply]
My main concern is that there are hundreds (maybe thousands) of infoboxes that have PFR linked in them but don't provide stats in the infobox. E.g. Rudy Kuechenberg, with the new infobox code, this PFR link disappears. Is that the intended consequence of these changes? If so, then there needs to be some consensus for this change, because I am not sure I support it. So basically, the way the code is being proposed is for the PFR link to appear, there needs to be stats included. I would say that if no stats are included, the link should remain in its current location at the bottom of the infobox. « Gonzo fan2007 (talk) @ 16:31, 15 October 2024 (UTC)[reply]
Not intended and I thought I saw it working in the sandbox before it went live. I'll see if it can fall back to the bottom if no stats are present. ~ Dissident93 (talk) 16:55, 16 October 2024 (UTC)[reply]
I think there used to be a line above the PFR link. Without the line, do you think there is too much space or no? Example: Tom Tumulty. ~WikiOriginal-9~ (talk) 01:06, 16 October 2024 (UTC)[reply]
The line served no purpose and showed even when no links were provided. The gap should be fixed on the new version. ~ Dissident93 (talk) 16:57, 16 October 2024 (UTC)[reply]
Yeah I always thought the line was unintentional and made it look like the infobox could have been coded better. I'm a fan of it being gone when no stats are present. Hey man im josh (talk) 17:40, 16 October 2024 (UTC)[reply]
Fixes are live. Stats links should now fall back to the bottom of the infobox if no stats are provided (based on empty statvalue parameters). The wording now says "Stats at Pro Football Reference", which seems like it could be improved. I also added a header box to modules (check Rudy Bukich). ~ Dissident93 (talk) 21:06, 16 October 2024 (UTC)[reply]
Related, but I've also gone ahead and provided dark mode fixes for the color module and made the gridiron alt primary style template apply the primary color to the border as an inverse of the normal style. ~ Dissident93 (talk) 02:10, 17 October 2024 (UTC)[reply]
[edit]

We should populate the infoboxes with links pulled from Wikidata. I've checked a bunch of random NFL player Wikidata items and I haven't found one yet without a functioning PFR link. This would be better than doing it manually. There are still a lot of infoboxes that don't have them.

I think Bagumba said that the basketball infobox does this but I looked at the code and I'm not quite sure what's going on there yet, so if someone figures it out before me, that would be great. ~WikiOriginal-9~ (talk) 01:57, 17 October 2024 (UTC)[reply]

Good idea, I can take a look into it later. I know other infoboxes like the one for video games do this, so it might be as simple as copypasting with minor adjustments. ~ Dissident93 (talk) 02:07, 17 October 2024 (UTC)[reply]
For reference, I just did the WNBA BBR request [3]. It seems NFL ibx also has links for coaches and execs. —Bagumba (talk) 04:19, 17 October 2024 (UTC)[reply]
If possible that would be amazing. I literally signed up and started editing to add PFR links to profiles because I was annoyed when I couldn't find them when looking up players I had in fantasy. Hey man im josh (talk) 12:36, 17 October 2024 (UTC)[reply]
Retrieved from "https://en.wikipedia.org/w/index.php?title=Template_talk:Infobox_NFL_biography&oldid=1251676036"