User talk:Ronhjones/rescaledsidebar.js
Script not working?[edit]
Hi, Ronhjones. I was going to work on Category:Non-free files with orphaned versions more than 7 days old needing human review, but the "rescaled" tool is gone from my sidebar. I tried the script with the tab (which now seems to be the same script), but no "rescaled" tab; I bypassed my Firefox cache each time. I couldn't do the revdeletions manually either, though, so it may not be you :-). Thanks and all the best, Miniapolis 15:05, 10 February 2019 (UTC)
- @Miniapolis: Rats! Dead for me. Something must have changed in the wiki software. The other one still works (User:Ronhjones/rescaled.js) - but that adds a rescaled link to the top menu (OK for me - I use monobook, so an extra tab). Neither are my scripts - this one is a mod of User:B/rescaledsidebar.js script with a change of just the RegEx to work with that category. No idea therefore how to fix it. They keep on tweaking the js system - I used to use c:User:Rillke/SVGedit.js to edit SVG on the screen - that had a sidebar link, and that went a couple of months ago, at the same time they stopped editors editing another's js pages - I suspect another security hole has been blocked. I'll ping B - he might know what is wrong.Ronhjones (Talk) 16:09, 10 February 2019 (UTC)
- Thanks for the quick reply, Ronhjones. Unfortunately, I can't get the top-tab version to work in Vector. I removed the gadget which added "Purge" to the "More" tab (thinking there might be a conflict), but no luck; life is never dull on WP :-). Thanks again and all the best, Miniapolis 16:39, 10 February 2019 (UTC)
- @Miniapolis and Ronhjones: I have no idea what might have changed in MediaWiki, I have fixed in in my script by using an "old school" function. It seems that using mw.loader to add the sidebar link doesn't work any more. Maybe that API function changed? Take a look at [1] - I replaced the mw.loader function with an old school function that just uses the DOM to add the link. It's not a good programming practice - you should use the API when there is an API - but it works. (A better option would be to look and see what changed in the API and use whatever new parameters they want us to use. An even better option would be for MediaWiki developers to not have breaking changes in their code.) I have tested my change and it works. The new sidebar link says "Remove Orphaned old version" - since that is more meaningful than "rescaled". --B (talk) 18:30, 12 February 2019 (UTC)
- @Miniapolis and B: Dear B, Thanks for that. I "borrowed" your piece so my code now works. The Shift-Alt-S is still lost, which was a very nice feature. At least we can now process the Category:Non-free files with orphaned versions more than 7 days old needing human review again. Ronhjones (Talk) 19:02, 12 February 2019 (UTC)
- Thanks for the ping, Ronhjones and thanks, B. Having to remove the tags manually is no biggie, but when I tried to do the revdeletions manually I got an error message saying that the revision was already deleted (even though it wasn't :-)). Should I leave a note on VPT? All the best, Miniapolis 19:54, 12 February 2019 (UTC)
- @Miniapolis:Not sure - I just did File:The Hours poster.jpg manually - clicked the "(change visibility)" link and it worked for me. Ronhjones (Talk) 20:48, 12 February 2019 (UTC)
- Thanks for the ping, Ronhjones and thanks, B. Having to remove the tags manually is no biggie, but when I tried to do the revdeletions manually I got an error message saying that the revision was already deleted (even though it wasn't :-)). Should I leave a note on VPT? All the best, Miniapolis 19:54, 12 February 2019 (UTC)
- @Miniapolis and B: Dear B, Thanks for that. I "borrowed" your piece so my code now works. The Shift-Alt-S is still lost, which was a very nice feature. At least we can now process the Category:Non-free files with orphaned versions more than 7 days old needing human review again. Ronhjones (Talk) 19:02, 12 February 2019 (UTC)
- @Miniapolis and Ronhjones: I have no idea what might have changed in MediaWiki, I have fixed in in my script by using an "old school" function. It seems that using mw.loader to add the sidebar link doesn't work any more. Maybe that API function changed? Take a look at [1] - I replaced the mw.loader function with an old school function that just uses the DOM to add the link. It's not a good programming practice - you should use the API when there is an API - but it works. (A better option would be to look and see what changed in the API and use whatever new parameters they want us to use. An even better option would be for MediaWiki developers to not have breaking changes in their code.) I have tested my change and it works. The new sidebar link says "Remove Orphaned old version" - since that is more meaningful than "rescaled". --B (talk) 18:30, 12 February 2019 (UTC)
- Thanks for the quick reply, Ronhjones. Unfortunately, I can't get the top-tab version to work in Vector. I removed the gadget which added "Purge" to the "More" tab (thinking there might be a conflict), but no luck; life is never dull on WP :-). Thanks again and all the best, Miniapolis 16:39, 10 February 2019 (UTC)
