MediaWiki talk:Filepage.css

Wrap long strings in File history's "Comments" table cell[edit]

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Please add the following CSS:

/* Workaround for T270741 */
.filehistory td:last-child,
.listfiles .TablePager_col_img_description {
    word-break: break-word;
    min-width: 10em;
}

Thanks, ‑‑Neveselbert (talk · contribs · email) 23:33, 23 May 2021 (UTC)[reply]

@Neveselbert: please provide an example page where the problem that this is meant to fix is currently occurring, along with what you expect the change will do below. — xaosflux ^Talk 01:26, 24 May 2021 (UTC)[reply]

@Xaosflux: please see T270741 and, for an example page, File:Reginald Yarnitz Freeson.jpg. The URL beneath "Comment" under #filehistory causes the page to zoom out dramatically on my mobile browser, and this has been a regular nuisance. This change will break long URLs and especially long words, while ordinary words will remain intact. ‑‑Neveselbert (talk · contribs · email) 01:42, 24 May 2021 (UTC)[reply]

@Neveselbert: that 59 character string? It looks fine to me, what version of what browser are you using? Are you trying to emulate a desktop mode in a mobile browser - if so you should expect that the browser tries to expand the window for you. That phab tasks seems to warn that this is expected, and it looks like you already worked around this for yourself in User:Neveselbert (mobile)/common.css correct? — xaosflux ^Talk 02:02, 24 May 2021 (UTC)[reply]

On hold will need to investigate and test this a bit. — xaosflux ^Talk 02:02, 24 May 2021 (UTC)[reply]

@Xaosflux: I'm using an iPad (browser Safari on the latest iPadOS) with Desktop view, and although it's not unexpected, it's still incredibly inconvenient while I'm on mobile. Yes, I have been able to do so in my alt account, and it works thankfully, although I would prefer to review my edits while logged out to avoid having to load all of my userscripts. ‑‑Neveselbert (talk · contribs · email) 02:11, 24 May 2021 (UTC)[reply]

@Xaosflux: Commons has just recently implemented this workaround and it works fine. ‑‑Neveselbert (talk · contribs · email) 01:59, 25 May 2021 (UTC)[reply]

Done — xaosflux ^Talk 22:19, 3 June 2021 (UTC)[reply]

Thanks. @Xaosflux: just to correct a mistake on my part, can you please change the following:

And then move the code below over to MediaWiki:Common.css, since it doesn't work on this page:

/* Workaround for T270741 */
.listfiles .TablePager_col_img_description {
    word-break: break-word;
    min-width: 10em;
}

Thanks again, ‑‑Neveselbert (talk · contribs · email) 23:34, 3 June 2021 (UTC)[reply]

Undone @Neveselbert: I've undone the change, now that it has been identified as defective. Also, there is a much bigger leap putting things in to common.css. There is no mention in phab:T270741 that this workaround will need to go site-wide. — xaosflux ^Talk 00:06, 4 June 2021 (UTC)[reply]
I'm not even convinced this is a problem - you say it only happens when you are using a mobile browser, but then specifically ask your browser to give you the non-optimized-for-mobile view? Sounds like a stop touching the hot stove condition....? — xaosflux ^Talk 00:08, 4 June 2021 (UTC)[reply]
No, I'm using a tablet, which is optimised for desktop-class browsing. ‑‑Neveselbert (talk · contribs · email) 00:10, 4 June 2021 (UTC)[reply]

@Xaosflux: you didn't need to remove it all. .filehistory td:last-child works perfectly fine. ‑‑Neveselbert (talk · contribs · email) 00:09, 4 June 2021 (UTC)[reply]
- I left at note at Wikipedia:Interface administrators' noticeboard for someone else to review your request. — xaosflux ^Talk 00:30, 4 June 2021 (UTC)[reply]
  @Xaosflux: would it not be OK just to implement the part that works for now? I'm sorry about my mistake, but the rest of the code isn't at all defective. ‑‑Neveselbert (talk · contribs · email) 00:39, 4 June 2021 (UTC)[reply]

Partly done: Implemented .filehistory as requested. Izno (talk) 19:23, 4 June 2021 (UTC)[reply]

Missing File section edit link in mobile web[edit]

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Please remove this fragment from the page:

/* fix minerva, which has weird magic with table-cells here */
.skin-minerva .mw-editsection {
	display: none !important;
}

It is causing the issue described at Wikipedia:Village pump (technical)#Missing File section edit link in mobile web.

It's impossible to tell what this was intended for (unless someone remembers where it came from – the edit history of this page is missing), but "weird magic with table-cells" on section edit links has been definitely removed from Minerva by me in the work on phab:T305971, so it's probably no longer needed. Matma Rex talk 06:26, 16 January 2023 (UTC)[reply]

Done — xaosflux ^Talk 10:05, 16 January 2023 (UTC)[reply]

@Matma Rex, this sounds like .in-block may have been the problem. Izno Public (talk) 17:41, 16 January 2023 (UTC)[reply]

Wrap long strings in Special:ListFiles' "Description" table cell[edit]

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Please add the following:

Thanks, ‑‑Neveselbert (talk · contribs · email) 16:35, 21 January 2023 (UTC)[reply]

Not done for now: What has changed since #Wrap long strings in File history's "Comments" table cell? Izno (talk) 01:47, 24 January 2023 (UTC)[reply]

Vector 2022. This issue is even worse in the new skin. ‑‑Neveselbert (talk · contribs · email) 01:49, 24 January 2023 (UTC)[reply]

It being a new skin does not change the quality of the change requested that caused it to be rejected in the first place. Izno (talk) 03:24, 24 January 2023 (UTC)[reply]

No, the change was rejected because this was the wrong place to do it. I should've made this request at MediaWiki talk:Common.css. ‑‑Neveselbert (talk · contribs · email) 03:31, 24 January 2023 (UTC)[reply]

Rereading that discussion I think I should've posted this request to MediaWiki talk:Common.css, as I'm not sure this fix will work here. ‑‑Neveselbert (talk · contribs · email) 02:44, 24 January 2023 (UTC)[reply]

Looking at the requested addition, yes, this is not the correct location to request a change. Common.css would be.

I do not anticipate this change would be accepted into Common.css given how they are editor focused. The pager tables on special pages need a general change to be more mobile friendly as tables are known not to be. Skins like Minerva and Timeless have had deliberate consideration for large tables. You can follow phab:T66577 for other points on the question.

Since I guess you use this special page a lot, you can today add the change to your local CSS if you have issues. Izno (talk) 03:31, 24 January 2023 (UTC)[reply]

Yes I already do that, but I often log out when reviewing my contributions as otherwise I'm having to load all my userscripts when I don't need them. I guess I could use a browser script. ‑‑Neveselbert (talk · contribs · email) 03:36, 24 January 2023 (UTC)[reply]

Or maybe MediaWiki talk:Vector.css might be where I could request this without interfering with mobile skins. ‑‑Neveselbert (talk · contribs · email) 03:42, 24 January 2023 (UTC)[reply]