Module talk:External links

This module contains several errors

I found two errors in this module that need fixing:

• Line number 562 and line number 666 (if not (local_value or local_value == '') then): The "not" is extended to the whole expression via parentheses, when it looks like it was meant to be not local_value or local_value == ''. By De Morgan's laws, it is currently equivalent to not local_value and local_value ~= '', which is just not local value
• Line number 931 (local somedataonwikidata = (short_links and false or true): This was clearly meant to be a use of lua's ternary expression "syntax" (for lack of a better word). However, the or will always trigger, as false is, well, falsy; as such, this expression will always short-circuit to local somedataonwikidata = true. This should probably instead be local somedataonwikidata = not short_links.

{{Lemondoge|Talk|Contributions}} 22:11, 12 April 2023 (UTC)

Update: Now  done. {{Lemondoge|Talk|Contributions}} 18:44, 9 May 2023 (UTC)