User talk:Sodtwentyfive

Welcome back[edit]

Thanks for volunteering to help with the templates. Let me know if you want me to step in. We'll see how the bot approval and test go. Dicklyon (talk) 04:20, 28 January 2022 (UTC)[reply]

@Dicklyon no problem. If I am able to get AWB access we should be good to go. Otherwise I might have to give you a couple of find/replace jobs. One thing I noticed but forgot to raise earlier was that you downcased the results in brackets in the seeds sections of numerous draws (example). Seeing as there are about 17k draws which have the capitalized format, either those edits should be reverted or consensus should be found to downcase the seeds' results in all articles. Sod25 (talk) 08:15, 28 January 2022 (UTC)[reply]

I assume there's consensus, since there was no pushback and there's no possible way that MOS:CAPS can be interpreted as suggesting capping there. It might be a good job for a bot, which will require re-affirming consensus. Dicklyon (talk) 16:38, 28 January 2022 (UTC)[reply]

Well there's unlikely to be much pushback when so few editors would be watching those old pages, but I agree with the changes. A bot would be a good idea once you have a robust set of regex patterns. Here's some issues I found looking through your edits (you've probably addressed some of them have already):

(Champions) [1] replace ''Champions'' with champions (note the removed apostrophes), as new draws don't italicize the word champions [2].
(Champion) [3] same as above but for ''Champion''.
(Final) [4]
(Final, retired) [5]
(Semifinals) [6]
(Quarterfinals) [7]
(Qualified) [8]
(Qualifying Competition) [9]
(Qualifying competition, Lucky loser) [10]
"Qualifying Competition" as the round header in the draw [11]
(Moved to main draw) [12]

Additionally, in these edits [13][14] you disrupted the before_name/after_name parameters, which broke the succession links the the navboxes. Sod25 (talk) 09:14, 29 January 2022 (UTC)[reply]

@Dicklyon forgot to ping. Sod25 (talk) 02:19, 30 January 2022 (UTC)[reply]

I self-reverted those disruptions. Getting a robust set of patterns will be a major pain. Dicklyon (talk) 03:33, 30 January 2022 (UTC)[reply]

Do you know a good way develop a robust set of patterns? And do I have to work through the JWB UI, which makes it hard to deal with order-dependent things, or is there a better way? Dicklyon (talk) 03:48, 30 January 2022 (UTC)[reply]

@Dicklyon: I've found online regex testers like https://regexr.com/ very useful in the past for building/testing regexes. Not sure what you mean by "order-dependent things". Sod25 (talk) 04:09, 30 January 2022 (UTC)[reply]

In JWB, I find (I think) that non-regex replaces don't work after regexes. I tend to start with a pretty board downcasing regex, then go back to caps in contexts that need them, counting on the replaces to work in order. Is there a better way? Maybe do everything in one big hairy expression? Dicklyon (talk) 04:30, 30 January 2022 (UTC)[reply]

@Dicklyon: that seems to be an ok way, but you can avoid matching patterns on lines that contain certain strings to save having to go back and re-capitalize things. In the case of the before_name/after_name parameters, you can put ^(?!.*_name)(.*) before the regex patterns and (.*)$ after to avoid matching lines that have "_name" in them, which will avoid touching the template parameters, e.g.

find:

^(?!.*_name)(.*)– Men's Singles(.*)$

and replace it with

$1– Men's singles$2

Which should hopefully work (I don't have access to AWB/JWB to test). Sod25 (talk) 04:49, 30 January 2022 (UTC)[reply]

OK, I'll work on getting to know the ?<! pattern thing. But if there are multiple contexts that I need to exclude, I need another level of magic. I've never learned regex until this JWB need came up. Dicklyon (talk) 05:12, 30 January 2022 (UTC)[reply]

@Dicklyon With respect to the before/after name paremeters, those should be downcased, the issue was that you turned "Zhuhai Open – Women's Singles" into "Zhuhai Open women's singles" - the dash needs to be preserved and "womens" should be capitalized to fully match the new title. Sod25 (talk) 06:04, 30 January 2022 (UTC)[reply]

Are there any currently broken that way (missing dash) that you've found? Dicklyon (talk) 04:16, 2 February 2022 (UTC)[reply]

The TolBot has done the 5425 moves now. See what you can do about any templates that might need fixing, and let me know if I need to run some of that. I'm going to take the cleanup edits slowly. Dicklyon (talk) 06:03, 30 January 2022 (UTC)[reply]

@Dicklyon I've made all the edit requests to the templates needing changes and they have been fulfilled. It looks like I won't be getting AWB permission, so I won't stick around any longer. The one job it'd be great if you could do is:

Remove the lowercase parameter from the infoboxes of all the articles with it in Category:Pages using infobox tennis tournament event with unknown parameters and Category:Pages using infobox tennis tournament year with unknown parameters. This should be achievable by replacing " *\| *lowercase *= *yes *\n" with nothing. All multi-sport even tennis articles (e.g. Olympics) used this parameter to make the template functional with their downcased article titles, but the parameter is now deprecated as all the titles have been downcased.

Other than that, the before_name/after_name parameters ideally should be downcased so the succession links don't point to redirects. Good luck the cleanup, and don't feel too much pressure to do it all. It might be easier to just revert your downcasing of the seeds' results so that it doesn't have to be implemented across 17k articles, but I'll leave that up to you. Sod25 (talk) 14:37, 30 January 2022 (UTC)[reply]

Thanks, I'll work on those things. I don't think having the succession links go through redirects is much of a problem, but I'll probably fix them as I do other things. And if I don't get all 17k articles appropriately downcased, it's still motion in the right direction. Maybe I'll request a bot... Dicklyon (talk) 21:46, 30 January 2022 (UTC)[reply]

Done removing the lowercase parameter. There are few things left in Category:Pages using infobox tennis tournament year with unknown parameters for other reasons. Dicklyon (talk) 22:00, 30 January 2022 (UTC)[reply]