Wikipedia:Bots/Requests for approval/PrimeBOT 15

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

PrimeBOT 15[edit]

Operator: Primefac (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 17:29, Saturday, April 8, 2017 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): AWB

Source code available: AWB

Function overview: Change syntax usage of {{Episode list/sublist}} to allow for greater compatibility.

Links to relevant discussions (where appropriate): BOTREQ, WikiProject TV discussion

Edit period(s): One time run

Estimated number of pages affected: ~3700

Exclusion compliant (Yes/No): yes

Already has a bot flag (Yes/No): yes

Function details: The syntax of {{episode list/sublist}} is being changed; the parameter given is currently the "article being transcluded TO", and this change (along with a module update) will update to be the "article being transcluded FROM". The exact code:

Find: \{\{Episode list\/sublist\s*\|(.*)
Replace: {{Episode list/sublist|%%title%%

Personally I've never used %%title%% in AWB, so I don't know of it's efficacy (but I'm told it works), and if necessary the code can be changed from %%title%% to {{subst:PAGENAME}}.

Discussion[edit]

As a note, this is AlexTheWhovian's project, so while I've checked the code and it looks fine to me, more philosophical questions like "why" can/should be handled by them. Primefac (talk) 17:29, 8 April 2017 (UTC)[reply]

Cheers for that, I've added this page to my watchlist for any questions. -- Alex^TW 17:37, 8 April 2017 (UTC)[reply]

Just repeating for clarification for admins, the following edits would first need to be made to Module:Episode list (which I can easily do as a template editor), but immediately after, the above edits would need to be executed by the bot, to prevent as little disruption as possible between the module implementation and replace implementation. I'm not overly familiar with bots, but I would assume that it would be best to implement the module changes after the trials and before the full approval. -- Alex^TW 17:45, 8 April 2017 (UTC)[reply]

@AlexTheWhovian: Will the trial break pages if the module edit hasn't been made yet? If so, we should do a trial in userspace. ~ Rob₁₃^Talk 10:04, 14 April 2017 (UTC)[reply]

@BU Rob13: It will not break any pages, no. What will happen is that summaries from the transcluded tables will appear in the articles that the tables are being transcluded to (nothing serious, just out of the ordinary); implementing the module edits will then restore this to hiding the summaries. Test cases exist in the module's sandbox, the module's testcases and my sandbox. -- Alex^TW 10:22, 14 April 2017 (UTC)[reply]

@BU Rob13: Any further questions for this? It's been two weeks since the last comment, and three since the approval request. -- Alex^TW 11:10, 28 April 2017 (UTC)[reply]

Nope, no further questions. I support the task, but I'm not a BAG member, so I can't approve a trial. Musikanimal, perhaps? ~ Rob₁₃^Talk 16:18, 28 April 2017 (UTC)[reply]

Do bot requests normally take this long? It's been a month since this was opened... -- Alex^TW 01:14, 8 May 2017 (UTC)[reply]

Only because you mentioned that you aren't sure about %%title%% - let's see 150 edits, and hopefully we can approve you quickly after that if it works out. Approved for trial (150 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. SQL^{Query me!} 02:43, 8 May 2017 (UTC)[reply]
- Trial complete.. @SQL:, it is done. Turns out it works perfectly fine. Guess I learned some new code! Primefac (talk) 21:54, 9 May 2017 (UTC)[reply]

Awesome! I have updated the module, as I detailed in my original post, ready for the approved run. And you learn something new everyday! -- Alex^TW 23:29, 9 May 2017 (UTC)[reply]

Looks like it did well. Approved. SQL ^{Query me!} 02:50, 10 May 2017 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.