Module talk:I18n/complex date
Appearance
Error at Olhadoko erreka
[edit]I'm getting "Lua error in package.lua at line 80: module 'Module:Linguistic' not found." Plaba123 (talk) 18:58, 21 November 2018 (UTC)
- That's because @Jarekt: synced this with Commons, but @Pppery: made a breaking change by RfD'ing Module:Linguistic. Not sure how to resolve that... Thanks. Mike Peel (talk) 21:04, 21 November 2018 (UTC)
- It amusingly highlights that we have at least one code path that is not executed as otherwise we would have had similar errors already, and I think I saw a few others of similar sort reviewing the module earlier:--Izno (talk) 21:39, 21 November 2018 (UTC)
if state.precision > 10 then -- precision > month return 'du $date1 au $date2' else -- "DE septebmbre" / "D'octobre" return require("Module:Linguistic").of(date1, 'fr') .. " à $date2" end
- @Izno: In fact, you've underestimated the amount of never-executed code here by a lot: the entire module is basically copied from commons but useless here, as (taking that code as an example) there is no reason for an English Wikipedia article to format a date in French. {{3x|p}}ery (talk) 00:20, 22 November 2018 (UTC)
- I think there needs to be a broader discussion over whether this kind of "multilingual" module should be allowed on the English Wikipedia (I'd argue no). {{3x|p}}ery (talk) 00:31, 22 November 2018 (UTC)
- @Pppery: Can you copy that back over to commons so that this won't happen again? Thanks. Mike Peel (talk) 00:32, 22 November 2018 (UTC)
- No, because I'm not a commons admin. {{3x|p}}ery (talk) 00:34, 22 November 2018 (UTC)
- @Pppery: Can you copy that back over to commons so that this won't happen again? Thanks. Mike Peel (talk) 00:32, 22 November 2018 (UTC)
- It amusingly highlights that we have at least one code path that is not executed as otherwise we would have had similar errors already, and I think I saw a few others of similar sort reviewing the module earlier:
Errors in date handling.
[edit]Using Special:Permalink/882254323:
{{#invoke:WikidataIB |getValue |ps=1 |P582 |qid=Q2269}}
→ Module:I18n/complex_date:15: attempt to call field '_Ordinal' (a nil value)
The same call on Commons produces "19th century".
I'll re-synchronise from Commons.
{{#invoke:WikidataIB |getValue |ps=1 |P582 |qid=Q2269}}
→ 2010{{#invoke:WikidataIB |getValue |ps=1 |P582 |qid=Q2269 |lang=fr}}
→ 2010{{#invoke:WikidataIB |getValue |ps=1 |P582 |qid=Q2269 |lang=zh}}
→ 2010年
That is now working as of this timestamp. I strongly recommend that future changes are fully tested before implementation. --RexxS (talk) 14:46, 24 February 2019 (UTC)
- @RexxS: I don't think this worked in any version of the module before the one you just created. Pppery, the demodulator 22:07, 25 February 2019 (UTC)
- Alert: χ, the module you simplified has cropped back up again as Module:Ordinal-cd. Pppery, the demodulator 22:20, 25 February 2019 (UTC)
- @Pppery: It has always worked on Commons using the modules there: c:Module talk:WikidataIB/testing #Earliest and latest date as qualifiers. Restoring the enwiki versions to the ones used in Commons fixed the problem illustrated by the first invoke in my previous post. So it's difficult to see how the changes/deletions made to the Commons modules since they were originally imported were not responsible for the error, but I don't intend to quibble about it. However, I really think we ought to be trying to keep modules working fully, rather than worrying about keeping the namespace tidy. In the long-term, I'd really like to consolidate the functionality of most of the dependent modules into WikidataIB – it's currently about 100kB or about the size of one or two images, so not a big load on the servers. But I need to find the time to sandbox a series of changes to reduce the number of dependencies. --RexxS (talk) 22:38, 25 February 2019 (UTC)
- Unfortunately, when trying to fix a problem that manifests itself on enwiki and not on Commons, the simplest fix is to re-import the contents of the modules from Commons. I recommend checking the testcases following changes from known, working code. --RexxS (talk) 22:38, 25 February 2019 (UTC)
- Alert: χ, the module you simplified has cropped back up again as Module:Ordinal-cd. Pppery, the demodulator 22:20, 25 February 2019 (UTC)
CKB translation
[edit]Hello, Please someone copy this and paste to the module (ckb translation is available now). Thanks! ⇒ AramTalk 14:02, 28 July 2019 (UTC)
Done. Thank you for the expansion, Aram. --RexxS (talk) 14:18, 28 July 2019 (UTC)