Talk:Kim Shin (general)

	This article is within the scope of WikiProject International relations, a collaborative effort to improve the coverage of International relations on Wikipedia. If you would like to participate, please visit the project page, where you can join the discussion and see a list of open tasks.International relationsWikipedia:WikiProject International relationsTemplate:WikiProject International relationsInternational relations articles
???	This article has not yet received a rating on the project's importance scale.

Korea Low‑importance

	This article is within the scope of WikiProject Korea, a collaborative effort to build and improve articles related to Korea. All interested editors are invited to join the project and contribute to the discussion. For instructions on how use this banner, please refer to the documentation.KoreaWikipedia:WikiProject KoreaTemplate:WikiProject KoreaKorea-related articles
Low	This article has been rated as Low-importance on the project's importance scale.

Biography: Military

	Biography portal This article is within the scope of WikiProject Biography, a collaborative effort to create, develop and organize Wikipedia's articles about people. All interested editors are invited to join the project and contribute to the discussion. For instructions on how to use this banner, please refer to the documentation.BiographyWikipedia:WikiProject BiographyTemplate:WikiProject Biographybiography articles
	This article is supported by the military biography work group.

Article title change

Hey,

Sincere thank you for creating the article. Help is always appreciated here. However, the WP:QUALIFIER "general officer" is a bit unusual; most people will read "general" to mean "usual". Either "general" or "military officer" would have worked, but not "general officer" imo.

Is it ok if we rename the article "Kim Shin (general)"? toobigtokale (talk) 05:30, 6 May 2023 (UTC)[reply]

I understand what you mean. I contemplated it. But general have two meanings. For example, General means all kind of general officers and 4 star general. And there are so many articles of American generals in English Wikipedia. So I selected general officer to clarify. Let me sleep on it. I have a question. Are you English native speaker? Anyway thanks for your advice.

Footwiks (talk) 06:47, 6 May 2023 (UTC)[reply]

Yes native English speaker toobigtokale (talk) 09:07, 6 May 2023 (UTC)[reply]

I think that 'General' cause confusion. Is there no need to worry? Footwiks (talk) 10:36, 6 May 2023 (UTC)[reply]

Using "General" is common practice for parenthetical disambiguators, even for generals across many different cultures and time periods. You can click through various pages from here and see they all use "general", even if their specific rank differed. toobigtokale (talk) 17:19, 6 May 2023 (UTC)[reply]

Hm actually now I'm seeing that several pages use the "general officer" disambiguator. Like this Kim Suk-won (general officer) and this Bikram Singh (general officer). Maybe it's ok; I just didn't really know about the distinction. toobigtokale (talk) 17:24, 6 May 2023 (UTC)[reply]

OK, I agree on "General" is common practice. I amended the titles. I can't change one title

Can you move? John Pope (general officer) => John Pope (general)

Any Thanks for your advice. Footwiks (talk) 09:16, 7 May 2023 (UTC)[reply]

Hi, just saw this sorry.

Hm that article was able to get "good article" status with that title. I'm personally not too familiar with military ranks, but I'm assuming the title was fine. I think the title on this article was possibly fine too, but again not sure. toobigtokale (talk) 23:08, 10 May 2023 (UTC)[reply]

Missing info

Hi, I fleshed out the article a lot. I think it comfortably sits at a low C rating, as it's missing a lot of info from major parts of his life. A lot of the sources I used are also pretty mid-to-low quality (no peer reviewed sources, some source their info from him or his family), so third party academic books or articles are needed. toobigtokale (talk) 23:13, 29 June 2023 (UTC)[reply]