Jump to content

Wikipedia:Bots/Requests for approval/JCW-CleanerBot

Add links
From Wikipedia, the free encyclopedia
The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

JCW-CleanerBot[edit]

Operator: Headbomb (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 16:20, Thursday, August 17, 2017 (UTC)

Automatic, Supervised, or Manual: Sometimes automatic, sometimes semi-automated

Programming language(s): WP:AWB

Source code available: Simple regexes

Function overview: To properly format journal names on Wikipedia, with AWB general fixes as a side-benefit. For the exact details, see User:JCW-CleanerBot#Logic.

Links to relevant discussions (where appropriate):

Edit period(s): After data dumps

Estimated number of pages affected: 10,000 ish?

Namespace(s): Main space mostly. Occasionally in other spaces.

Exclusion compliant (Yes/No): Yes

Function details:

Note: For the exact details, see User:JCW-CleanerBot#Logic.

The idea is to look in WP:JCW, and find common misspellings of journal names and abbreviations. I plan on doing edits such as

  • Closing entries with exposed '(journal)' disambiguators. [1]
  • Fixing bad abbreviations. [2]
  • Fixing bad journal names such as Animal Behavior → Animal Behaviour
  • Fix non-standard pseudo-ISO 4 abbreviations to correct ISO-4 abbreviations (Nucl. Acids Res. → Nucleic Acids Res.)
    • This excludes pseudo-ISO 4 abbreviations which may be standard in a field, such as Amer. Math. Month.. The bot will leave those alone.
  • Fixing capitalization mistakes, such as The Lancet. Infectious diseases → The Lancet. Infectious Diseases
  • And other fixes of similar nature.

The bot will mostly operate on |journal= of citation templates, but will sometimes cleanup non-|journal= entries when it can guarantee to not screw things up like improperly removing dots in places dots shouldn't be removed (The article appeared in the Journal of Chemistry. → The article appeared in the Journal of Chemistry), or changing the capitalization of things that should not be changed (this animal behaviour was first seen in ..." → this Animal Behaviour was first seen in ...")

I'll be performing database scans, and develop regexes tailored to each misspelling. Sure shots one will be performed automatically, tricky ones will be performed semi-automatically. I have done this for years on my main account, but have often left the big ones with hundreds of instances because I couldn't be bothered to mindlessly click 'save' 200 times. Headbomb {t · c · p · b} 16:20, 17 August 2017 (UTC)[reply]

Discussion[edit]

  • I personally don't have a problem with all of the points, except number 3 which I believe violates WP:CONTEXTBOT. Is there any consensus for this particular fix?—CYBERPOWER (Chat) 18:00, 17 August 2017 (UTC)[reply]
  • Thank you for including the exception for field-standard non-ISO journal abbreviations. That would have been my only concern, but you have already addressed it. —David Eppstein (talk) 18:01, 17 August 2017 (UTC)[reply]

I suggest a 100 edit (semi-automated) trial. I could also do a 50 edit automated trial, but that would pretty boring (e.g. 13x Botanical Journal of the Linnaean Society → Botanical Journal of the Linnean Society, followed by 25x Ann Intern Med. → Ann Intern Med, and so on.) Headbomb {t · c · p · b} 18:52, 17 August 2017 (UTC)[reply]

  • Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.—CYBERPOWER (Around) 06:24, 20 August 2017 (UTC)[reply]
  • Trial complete.
    • [3] - Trial, part 1. I took the liberty of extending the task to also cover [[Foobar (magazine)]] → [[Foobar (magazine)|Foobar]] in |magazine= since it's just as easy to find in database scans. Task worked perfectly, with no errors to report. This is an example of a task that would run automatically.
      • Could I also include those in |publisher=/|work= and [[Foobar (publisher)]] → [[Foobar (publisher)|Foobar]]? I haven't done this in the trial, but I've tested it on my main account ([4], [5]) and it work just as flawless at those above. Headbomb {t · c · p · b} 00:02, 21 August 2017 (UTC)[reply]
        • This batch of edits look good, so go ahead. I'm checking the next batch.—CYBERPOWER (Chat) 16:41, 21 August 2017 (UTC)[reply]
    • [6] - Trial, part 2. Semi-automated mode. I skipped typo fixing, but I plan to run with them when in this mode. I exceeded my trial by 2 edits so it would be easier to resume (I stopped at entry 250 in WP:JCW/TAR). I've done those edits for years without anything contentious / any objections coming out of it, so I don't see why it would become contentious now, but it would be good to have a detailed review + questions before full approval. Headbomb {t · c · p · b} 20:31, 20 August 2017 (UTC)[reply]
      • I'm a bit concerned about scope creep. I agree with everything you're doing, but it's a lot to be done in one bot task. Could you put together a subpage in the bot userspace (or your userspace) that explains each of the fixes fully, ideally with diff examples? Further, could you link that subpage from the edit summary of the bot? I just want to make sure that the average editor understands what's being done in the edits. ~ Rob13Talk 00:22, 21 August 2017 (UTC)[reply]
Done at User:JCW-CleanerBot#Logic. I'll update the edit summary to point to it during runs. Headbomb {t · c · p · b} 01:45, 21 August 2017 (UTC)[reply]
I'll ping Cyberpower678 (talk · contribs) to ensure review of User:JCW-CleanerBot#Logic. I've broken down the 6 main types of fixes I've been doing in the past years. Headbomb {t · c · p · b} 02:23, 21 August 2017 (UTC)[reply]
  • So regarding your second batch of edits, what happened here? No visible change in output and no change within the bot's scope. At least I don't see one.—CYBERPOWER (Chat) 16:53, 21 August 2017 (UTC)[reply]
It changed Phils. Trans. to Phil. Trans. (plus a couple of MOS:PERCENT fixes). Headbomb {t · c · p · b} 16:58, 21 August 2017 (UTC)[reply]
  • Remaining issues have been discussed on IRC.—CYBERPOWER (Chat) 17:11, 21 August 2017 (UTC)[reply]

Phase 2[edit]

  • Approved for trial (50 edits (Task A) and 50 edits (Tasks E and F)). Please provide a link to the relevant contributions and/or diffs when the trial is complete.—CYBERPOWER (Chat) 17:10, 21 August 2017 (UTC)[reply]
  • [7] Part 1A trial. Headbomb {t · c · p · b} 17:15, 21 August 2017 (UTC)[reply]
    The edits themselves look good, but none of them demonstrate Task A. I wanted to see the bot fix some typos here.—CYBERPOWER (Chat) 18:08, 21 August 2017 (UTC)[reply]
    I'm not running typo fixing on task A, because I'm doing this one automatically and WP:CONTEXTBOT applies. I'll find examples of typo fixing in the semi-automated run below however. Headbomb {t · c · p · b} 18:12, 21 August 2017 (UTC)[reply]
  • [8] Part E/F trial. Edits containing typo fixing: [9] [10]. Those are the only two instances of typos in this run.
  • In [11], the change is in the last entry.
  • In [12], the publication is fully bilingual. I suppose I could have used "Journal of Orofacial Orthopedics / Fortschritte der Kieferorthopädie", but as the cited title was in English, the English title of the journal was chosen (as is normally done).
  • [13] and [14] screwed up [didn't copy-paste things correctly], but I rectified it [15] [16].
Headbomb {t · c · p · b} 18:10, 21 August 2017 (UTC)[reply]
Task A according to your bot's page is typo fixing, but ok.—CYBERPOWER (Chat) 18:18, 21 August 2017 (UTC)[reply]
Oh, I see what you mean. I thought you mean 1A for extending the disambiguator logic to magazines/publishers, so that's the trial I did. I brainfarted there (mostly because I didn't see the point in testing legit typo/mispelling fixes since those are foolproof). I'll do 50 of those then, although I'll be a pretty boring trial. Headbomb {t · c · p · b} 18:23, 21 August 2017 (UTC)[reply]
  • [17] Real task A trial. Headbomb {t · c · p · b} 18:50, 21 August 2017 (UTC)[reply]
    So I have been giving this some thought, and these typo fixes are strictly applied to Journal names correct?—CYBERPOWER (Chat) 07:17, 22 August 2017 (UTC)[reply]
    Well, there would be two types of typo fixes. In automated mode, it's a tightly controlled 'match EXACTLY this in |journal=' and nowhere else. In semi automated mode, they may be additional typo fixes (AWB-based ones, always manually reviewed), and I'm letting the find/replace apply outside of |journal=, but only if it refers to the actual publication, and not random words.
    So for a case like
"Bob is a paleontology amatuer who published an articles in the journal Paleontology.<ref>{{cite journal |journal=paleontology}}</ref>"
In automated mode, the bot would do
"Bob is a paleontology amatuer who published an articles in the journal Paleontology.<ref>{{cite journal |journal=Palaeontology}}</ref>"
while in semi-automated mode, the bot would do
"Bob is a paleontology amateur who published an articles in the journal Palaeontology.<ref>{{cite journal |journal=Palaeontology}}</ref>"
In all cases, the bot would leave the first use of paleontology alone, as this is WP:ENGVAR stuff. The others uses concern the actual name of the publication and ought to be spelled correctly, and those are the cases the bot is interested in. In automated-mode the bot only touches |journal= (e.g. [18]). In semi-automated mode, I can catch more (e.g. [19]) since I'm making sure those it touches are legit cases of a typo. Headbomb {t · c · p · b} 09:34, 22 August 2017 (UTC)[reply]
The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.
Retrieved from "https://en.wikipedia.org/w/index.php?title=Wikipedia:Bots/Requests_for_approval/JCW-CleanerBot&oldid=830248632"