Wikipedia:Bots/Requests for approval/Yobot 54

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

Yobot 54

• (BRFA
• Approved BRFAs
• talk
• contribs
• count
• SUL
• logs
• page moves
• block log
• rights log
• flag)

Operator: Magioladitis (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 09:40, Saturday, March 25, 2017 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): AWB

Source code available:

Function overview: Replace ISBN / PMID / RFC magiclinks with ISBN / PMID / RFC template

Find: \b(ISBN)((?:[^\S\n]| |&\#0*160;|&\#[Xx]0*[Aa]0;)+)((?:97[89](?:-|(?:[^\S\n]| |&\#0*160;|&\#[Xx]0*[Aa]0;))?)?(?:[0-9](?:-|(?:[^\S\n]| |&\#0*160;|&\#[Xx]0*[Aa]0;))?){9}[0-9Xx])\b

Replace: {{ISBN|$3}} Links to relevant discussions (where appropriate):

• Wikipedia:Village_pump_(proposals)#Future_of_magic_links
• Future of magic links / making ISBN linking easier
• T148274

Edit period(s): One off and revisit

Estimated number of pages affected: Roughly 400,000 + 7,000 + a few more

Exclusion compliant (Yes/No):

Already has a bot flag (Yes/No): Yes

Function details: AWB's Find and Replace. It will skip page if not applicable. General fixes will be done in addition. Example: ISBN 123456789-0 → ISBN 123456789-0

Discussion

@Legoktm, Bgwhite, and MZMcBride: -- Magioladitis (talk) 09:47, 25 March 2017 (UTC)

See also previous discussion: Wikipedia:Bots/Requests for approval/Yobot 27. Now there is also clear consensus to proceed. -- Magioladitis (talk) 09:47, 25 March 2017 (UTC)

What regex are you using to detect the ISBN magic links? See also Wikipedia:Bots/Requests for approval/PrimeBOT 13 where this same task has been proposed (it may be ok to have two bots working on this, as long as they both actually do the same replacements). Anomie⚔ 12:51, 25 March 2017 (UTC)

Anomie I'll be using pretty much the same with PrimeBot. I have not noticed the other bot. I have proposed this a long time ago and reopened it.

ISBN[\s\t]*(([0-9]|-|–|X)+)→{{ISBN|$1}}

I'll be catching a bit more since I also check for tabs between ISBN and the number. -- Magioladitis (talk) 12:56, 25 March 2017 (UTC)

As I mentioned on the other task, the regular expression used by MediaWiki for this purpose is different. To what extent does the community care about bots catching additional ISBNs that aren't currently magic links? Anomie⚔ 13:00, 25 March 2017 (UTC)

Anomie Since PrimeBOT will be using AWB we can cooperate to have the same regex if there are two bots to do this. Whatever suits best. There are very few cases that are not magic links and are detected in Wikipedia:WikiProject Check Wikipedia/ISBN errors. Me and other are fixing these. Notice that the list has dropped drastically the last few months. -- Magioladitis (talk) 13:02, 25 March 2017 (UTC)

This task does not require general fixes, and they should be disabled. Yobot in particular has had longstanding issues with unnecessary fixes; it's better to stick just to the specific task at hand rather than adding unrelated edits to the task. This is particularly the case for a job of this size. — Carl (CBM · talk) 13:04, 25 March 2017 (UTC)

There seems to be a consensus that there are tasks that should be done as secondary tasks. No task actually requires other tasks. Exactly of the size if a good opportunity to perform hundreds of other minor tasks in a single run. Moreover, a F&R is ideal for skipping when the primary tasks has not been fixed. -- Magioladitis (talk) 13:07, 25 March 2017 (UTC)

I don't think there is any such consensus. Yobot has a track record of problems with general fixes, so it makes particular sense for them to be disabled until a better track record is established. Thus is an area where BAG can show more oversight going forward. — Carl (CBM · talk) 13:11, 25 March 2017 (UTC)

Cc: @Headbomb: -- Magioladitis (talk) 13:21, 25 March 2017 (UTC)

While there is a consensus that general fixes can be done alongside a task, and that this would cover so many pages that we might as well apply genfixes, there is a history of Yobot not following WP:COSMETICBOT. Since many such genfixes are cosmetic in nature, and that you've had a full/recently closed ARBCOM case on this specific issue, the community's concern are valid. To be approved to run with genfixes, you would, at the very least, need to both skip if only minor genfixes fixes are made, and skip if only cosmetic genfixes are made. But because of Yobot's history, it might be best if the bot is only allowed to make an edit iff the task's main purpose would have triggered an edit. However, I'd rather let someone else from the BAG make the final decision, because I have advised you too many times on this. Headbomb {talk / contribs / physics / books} 13:54, 25 March 2017 (UTC)

IMO "the bot is only allowed to make an edit iff the task's main purpose would have triggered an edit" would be satisfactory and should be followed by all bots making genfixes. Also, if we wind up with multiple bots doing the task, ideally they should try to avoid a situation where they make different general fixes such that one edit conflicting with the other results in MediaWiki producing a merged edit that appears to be fixes-only. Anomie⚔ 14:45, 26 March 2017 (UTC)

It's good guidance in general, but there are exceptions. For instance bots operating on data dumps will often run into an instance of their task having already been done. I don't see the benefit of restricting an otherwise non-contentious bots from doing non-cosmetic genfixes (like properly closing a ref template/malformatted wikilink). Headbomb {talk / contribs / physics / books} 15:13, 26 March 2017 (UTC)

Each bot edit is supposed to be backed up by a BRFA. If the goal is to fix malformed wikilinks, that is a separate task from this one, which should be run with a separate edit summary. One of the longstanding problems with Yobot was that it did not use clear edit summaries that identified the specific goal of each edit. If a particular bot task no longer applies to a particular page, it's common sense that a bot running that task should skip the page, rather than claiming to fix a problem that no longer exists. — Carl (CBM · talk) 15:47, 26 March 2017 (UTC)

That's why such bots should have "and AWB genfixes" in their summary somewhere. I also highly encourage the AWB team to develop a list similar to WP:CWERRORS where they could deliver a blow-by-blow list of genfixes done, but that this beyond the scope of this BRFA. Headbomb {talk / contribs / physics / books} 15:59, 26 March 2017 (UTC)

But that edit summary does not permit them to go ahead and make the genfixes if the approved task does not apply. Otherwise, they could just run the "approved" task on every article to make genfixes.... The genfixes are only valid when the approved task is also performed. As I said, one of the lonstanding problems with Yobot was bad edit summaries, such as vague references to CHECKWIKI, which made it impossible to tell what approved task was actually running. Going forward, BAG needs to rein in the edits so that they more precisely match the approved tasks. — Carl (CBM · talk) 16:02, 26 March 2017 (UTC)

Edit summaries permit nothing. BRFAs and consensus do. The edit summary addresses the issue of WP:BOTCOMM per our requirements. The community has always accepted a small false positive rate on editing conditions, as long the edits made were not contentious. If a bot runs against say CW Error #32, and 3 out of the listed 80 instances of the error were already fixed by the time the bot got to it, and the bot happens to fix something else instead (e.g. fixing categories), that is fine even if the main scope of its task isn't to fix categories. This of course, assumes the bot was approved to do AWB genfixes alongside its main task. Headbomb {talk / contribs / physics / books} 17:25, 26 March 2017 (UTC)

We are off-topic. This was already done by Yobot for CHECKWIKI with very few exceptions due to other problems. For example the #104 error was supposedly being fixed with error ratio < 1% till an error in the list generation and not in the code added more pages in the list which resulted in a disaster. This fact was overlooked during the ArbCom. Anyway, this bot task is cut-clear because AWB provides a very specific skip condition in case the ISBN is not fixed. The error ratio will be 0%. -- Magioladitis (talk) 17:41, 26 March 2017 (UTC)

Headbomb We, as AWB team, already have WP:GENFIXES. -- Magioladitis (talk) 17:21, 26 March 2017 (UTC)

And that list is non-exhaustive. Compare with WP:CWERRORS where each error is identified and categorized. In theory, it is possible to have a bot have a blow-by-blow edit summary such as "Fixing CW Error #01, CW Error #02 CW Error #04, CW Error #41 and CW Error #88". With AWB, we are not told much except "general fixes". The WP:GENFIXES pages is also not linked by default. I'll file a phabricator ticket for this actually. Headbomb {talk / contribs / physics / books} 17:29, 26 March 2017 (UTC)

Yes, I agree the edit summary should list the actual changes being made - Magioladitis has been asked to do that for years, but has declined. It would be good for BAG to require it for CHECKWIKI fixes going forward. On the other hand, an edit summary of "Fix problem ZZZ and/or do general fixes" is so vague that the operator could just run it on every page, regardless whether the page ever had problem ZZZ. That is not what BRFAs are meant to approve. — Carl (CBM · talk) 17:33, 26 March 2017 (UTC)

And if a bot starts to primarily do genfixes, it can be blocked as running outside its approval. Theoretical bad faith concerns are outside the scope of this BRFA. I'll also remind you that like ARBCOM, BAG cannot dictate software development. While we could certainly ban AWB-based bots until certain software features are implemented, it would be gigantically detrimental to do so, especially when in the vast majority of cases this is not an actual issue. Perfect is the enemy of good. Headbomb {talk / contribs / physics / books} 17:52, 26 March 2017 (UTC)

The point of a BRFA is to vet both the task and the bot operator - it is not at all outside the scope of a BRFA to look at all aspects of the request, and even to say that a task is theoretically OK but should be run by a different operator. One of the things that led to the arbitration case was previous BAG members who did not do sufficient vetting of tasks, leading to vague approvals. We know from experience that, unless everything is laid out in very specific detail, the scope of Yobot bot runs has a tendency to grow well beyond what was originally approved. We know that the jobs have often been run on inaccurate lists. One job of BAG is to find a way, with in the BRFA process, to obtain better outcomes. — Carl (CBM · talk) 18:37, 26 March 2017 (UTC)

@Headbomb: Perfect. I will ask PrimeBot if they an do the same. -- Magioladitis (talk) 14:09, 25 March 2017 (UTC)

Primebot and Primface are under no arbcom restrictions, and have no history of WP:COSMETICBOT violations. There is little reason to withhold genfixes from that bot's task, or be concerned that it would not have those skip conditions enabled. Headbomb {talk / contribs / physics / books} 14:12, 25 March 2017 (UTC)

Headbomb OK. Happy to hear that. If Primfac/Primebot is approved to do the task with general fixes on ad the problem is only mistrust fpr my bot, I'll leave the entire task to them and I will help with bug fixing. -- Magioladitis (talk) 14:17, 25 March 2017 (UTC)

As one of the harshest critics of Magioladitis, I have to say, I think he's being treated extremely unfairly here. If he has "skip if no replacement" checked, there is a 0% chance of error on cosmetic edits. The only potential concern is that he would lie to us about checking that option, but I certainly don't think that's at all likely. If a cosmetic edit is made, we'd be able to clearly see that the option wasn't checked and react accordingly. The remedies allowing blocking of his bot as an AE action are intended to allow him to get back to normal bot operation, not be used as an excuse to refuse tasks that would be approved for other bot operators. If anything, he should be encouraged for coming to the table with a very reasonable proposal to use genfixes and a clear idea of how to avoid cosmetic editing. ~ Rob₁₃^Talk 15:46, 25 March 2017 (UTC)

The issue is not only cosmetic edits, although it would be unwise to ignore that issue. Look at the example of BenderBot, which replaces http with https in some URLs. One reason that task draws few complaints is that the bot sticks to the desired task without making additional, unrelated edits. This makes it much easier for editors to understand what the bot was doing. Diffs full of other changes can only cause confusion. — Carl (CBM · talk) 17:22, 25 March 2017 (UTC)

In which scenario a bot should do minor edits in addition then? -- Magioladitis (talk) 16:16, 26 March 2017 (UTC)

Some bot authorizations explicitly allow bots to perform other changes, like general fixes, as long as the main change is also made. That's when minor changes can be done. I don't think anyone is concerned about that - the issue is when the main change is not made, in which case the bot authorization doesn't apply, and the bot should not make any edit. — Carl (CBM · talk) 16:30, 26 March 2017 (UTC)

@CBM: Yes, but here the bot operator has provided a very clear method to avoid that issue – checking "skip if no replacement made". That option is 100% accurate; it skips if one of your main changes isn't implemented. So long as the main changes are coded properly (discussed below), that won't be an issue unless the bot operator is lying about checking that particular option. As I said before, I'm extremely confident he's not intentionally misleading us during the bot approvals process, but in the highly unlikely event he is, a single cosmetic-only edit related to this task would prove that. In that hypothetical situation (again, highly unlikely), proven intentional deceit at the bot approvals process would likely result in a long-term block based on the history. But let's give him some credit, both in the sense of his good-faith efforts to comply with the bot policy and his intelligence, and acknowledge that Magioladitis would not lie to us here, especially in a manner so easily caught. ~ Rob₁₃^Talk 16:40, 26 March 2017 (UTC)

The regex above is too broad. It would presumably catch "ISBN0123456789", which is not currently a magic link, and "http://www.example.com/booklink?ISBN0123456789", which is also not a magic link and should definitely not be converted. The bot needs to be limited to operating on articles in Category:Pages using ISBN magic links, and it should ideally use the same regex that Mediawiki uses to detect ISBNs to turn into magic links. – Jonesey95 (talk) 17:48, 25 March 2017 (UTC)

Jonesey95 True. I'll do some tests. Moreover, I'll ignore all urls, filenames, etc. using AWB's hide feature. -- Magioladitis (talk) 19:09, 25 March 2017 (UTC)

Jonesey95 In fact I plan to start by helping in manually fixing those in Wikipedia:WikiProject Check Wikipedia/ISBN errors to avoid unnecessary duplicated runs. -- Magioladitis (talk) 19:11, 25 March 2017 (UTC)

Thanks for picking this up again. Is there a reason you're only doing ISBN in this run and not PMID and RFC too? Legoktm (talk) 20:18, 25 March 2017 (UTC)

OK. I can do them too. -- Magioladitis (talk) 20:30, 25 March 2017 (UTC)

It should not need to be said, but edit summaries for this task should include the phrase "Task 54" and link back to this BRFA or to an up-to-date user page that links to this BRFA. – Jonesey95 (talk) 16:29, 26 March 2017 (UTC)

• Note I've started a conversation linking all three magic-link bots together here. Primefac (talk) 03:05, 18 April 2017 (UTC)

{{BAGAssistanceNeeded}} I ve already seen a bot that started the task! -- Magioladitis (talk) 18:01, 21 June 2017 (UTC)

2 bots started. I'll start manually too to help. -- Magioladitis (talk) 18:12, 21 June 2017 (UTC)

Magioladitis, you may want to check your edit summaries, they're... not really working right. You might want to use Special:PermaLink/... instead of the full URL. Primefac (talk) 18:24, 21 June 2017 (UTC)

Primefac Thanks. Fixed. You may also want that your bot runs out of mainspace. Maybe leave these to the very end? -- Magioladitis (talk) 18:25, 21 June 2017 (UTC)

They all have to be done eventually. Who cares in which order they're fixed? Primefac (talk) 18:26, 21 June 2017 (UTC)

Primefac In one case you "Fixed" a bug report to FrescoBot's page related to ISBN syntax. Maybe some should nnot be fixed. -- Magioladitis (talk) 18:28, 21 June 2017 (UTC)

If Yobot is using the same regex that Magioladitis was using (1, 2, 3, 4, 5, 6, 7, 8, 9), then the regex needs to be corrected. — JJMC89 (T·C) 22:07, 21 June 2017 (UTC)

JJMC89 Already noted and fixed. I already have fixed all the pages you noted too. Thanks, Magioladitis (talk) 22:54, 21 June 2017 (UTC)

This was also a problematic edit. Not sure if it actually got fixed in the code, given that the solution was simply to remove one of the ISBNs before running it again. Primefac (talk) 01:13, 22 June 2017 (UTC)

When an ISBN is in the actual title of a journal article, the best way I know how to fix it is to wrap the ISBN in nowiki tags. There were too many editors trying to fix this article (gnome edit conflicts, hooray!), but here's a diff that gets to the basic idea. – Jonesey95 (talk) 03:41, 22 June 2017 (UTC)

The issue wasn't {{ISBN|2503049117}}, 9782503049113 → {{ISBN|9782503049113}}, which was done manually; it was (1) ISBN 2 503 04911 7 → {{ISBN|2}} 503 04911 7 (AWB) and then (2) ISBN 2 503 04911 7 → {{ISBN|2-503-04911-7}} (manual). (1) is from bad regex. (2) and ISBN 2 503 04911 7 → ISBN 2-503-04911-7 shouldn't have been done since they altered the title of the work being cited by adding -. — JJMC89 (T·C) 03:58, 22 June 2017 (UTC)

Magioladitis, why aren't you using the same regex that the bots are using? It is working very well. – Jonesey95 (talk) 04:49, 22 June 2017 (UTC)

Primefac I did a lot of tese manually. These 2 ISBNs are identical. This has nothing to do with the bot run. I fix these manually for years. -- Magioladitis (talk) 05:30, 22 June 2017 (UTC)

Primefac I am also fixing these. AWB oes a lot of conversions but not all. The id parameters is very often abused to contain a second identical ISBN. -- Magioladitis (talk) 05:39, 22 June 2017 (UTC)

Jonesey95 Where is the regetx the bot use? I see only individual approvals that do not contain the approved regex. Here for instance: Wikipedia:Bots/Requests for approval/PrimeBOT 13 the final regex is not given. The regx used by Magic links bot is broken too: {{ISBN|\3}} is bad code. -- Magioladitis (talk) 05:32, 22 June 2017 (UTC)

Most recently at User talk:JJMC89.

I had a thought, though. Rather than trying to do the work that the bots are already doing, which is (clearly, as illustrated above) a waste of your time and that of others, follow behind the bots in article space (Magic Links Bot is up to articles starting with "H" at this writing) and fix the magic links that the bots were unable to fix. You will find many interesting and satisfying problems to work on. For example, I found articles that did not have any magic links left, but were transcluding Template:WdH or Template:Infobox comics character and title or Template:Black and Bolton 2001. By fixing those templates, I was able to fix a few hundred pages with just three edits. There are also magic links embedded in {{quote}} templates and [File] calls that need to be fixed using semi-automated editing with careful previews. – Jonesey95 (talk) 05:40, 22 June 2017 (UTC)

Jonesey95 I use pretty much the same. I use {{ISBN|$3}} instead of {{ISBN|\3}}. -- Magioladitis (talk) 05:42, 22 June 2017 (UTC)

If you were using "pretty much the same" regex, I don't see how you could have made (and saved without catching in preview) the edits linked above. I urge you to listen to good-faith, constructive advice. – Jonesey95 (talk) 05:46, 22 June 2017 (UTC)

Jonesey95 I adjusted to match the one you gave me with the correction I just wrote. From my normal avccount I do a lot of manual fixes too. Yobot won't do these. -- Magioladitis (talk) 05:49, 22 June 2017 (UTC)

Jonesey95 I updated the regex of my bot and the function details. Thanks for the link. -- Magioladitis (talk) 05:52, 22 June 2017 (UTC)

Anomie I adjusted to catch the same ISBNs with the other bots. I also suggest that all bots should share the same regex to avoid problems. -- Magioladitis (talk) 07:53, 23 June 2017 (UTC)

Xaosflux Please review this request. -- Magioladitis (talk) 06:18, 27 June 2017 (UTC)

@Anomie: would you mind taking this one? — xaosflux ^Talk 11:10, 27 June 2017 (UTC)

Running the regex in manual mode works fine. -- Magioladitis (talk) 08:24, 30 June 2017 (UTC)

BU Rob 13 denied to check the case: User_talk:BU_Rob13/Archive_8#ISBN. So we are in the search for another BAG member to look into this. -- Magioladitis (talk) 10:44, 30 June 2017 (UTC)

• Note, as I recently raised an ANI report about this operator somewhat related to this task, I am recusing from further activity on this specific request. — xaosflux ^Talk 12:08, 30 June 2017 (UTC)

Xaosflux That's why I believe that the community can't only depend on the volunteer activity of BAG. I appreciate it but theere is a policy/direction misig to determine whether a tactic is good or not. -- Magioladitis (talk) 12:12, 30 June 2017 (UTC)

Magioladitis, why is it so bloody difficult for you to be patient? There are dozens of projects that I know you want to work on (you've often listed them in various places), and there already are two bots working on this. No one is going to think less of you if your bot isn't the top-editing-ISBN-fixer. Have some tea. Primefac (talk) 13:39, 30 June 2017 (UTC)

Primefac Would you like to enable general fixes to your bot when editing mainspace? -- Magioladitis (talk) 13:51, 30 June 2017 (UTC)

If I headdesk and harder I'll break the table. You have an amazing ability to completely ignore anything that doesn't fit in your specific goals. Primefac (talk) 14:01, 30 June 2017 (UTC)

Primefac Recall that I was the one that proposed that you are the appropriate person to perfomr this task hoping that we will find a way to do in a way that we will do some general fixes. -- Magioladitis (talk) 14:41, 30 June 2017 (UTC)

It's not about being patient. I am fixing the reflists manually which is again hundreds of pages. I spent a lot of time in front of my monitor by just clicking Ctrl+S. --- Magioladitis (talk) 14:43, 30 June 2017 (UTC)

@Headbomb: Maybe you can take a look at my bot approval request? -- Magioladitis (talk) 08:39, 1 July 2017 (UTC)

Side-discussion on other bots synchronising

Primefac why do you deny to enable general fixes? Do you feel not that confident with AWB? I could provide online help if you wish. -- Magioladitis (talk) 22:21, 30 June 2017 (UTC)

First question: a) Because I didn't ask to and b) Because I don't want to.

Second question: seriously? Enabling genfixes is literally checking a box. There's no "confidence" about it. I always run genfixes if I'm doing something on my main acct. In this particular instance, though, I'm not, and see the answer to the first question for why. Primefac (talk) 22:29, 30 June 2017 (UTC)

Primefac Well it's not that easy. It comes with the responisiblity to report bugs and run 3rd party software. At least these are the common reason others report. I encourage you though to try it since you are an experienced bot operator. I also started a proposal that bot operators will optionally will have the chance to do this.-- Magioladitis (talk) 22:33, 30 June 2017 (UTC)

Primefac Since Yobot wil start the task and since Yobot will also do general fixes do you think it would be OK if you stop your bot to help more tasks to be done in a single edit? You can stll all the non-mainspace pages which Yobot won't visit. -- Magioladitis (talk) 22:35, 30 June 2017 (UTC)

Anomie Please note tat this bot will do more things in a single edit than the bots already approved. -- Magioladitis (talk) 23:18, 30 June 2017 (UTC)

Moving forward / Trial

So, let's see how this is going to work. For now, I would ask that you operate without general fixes for this task please - I am looking to evaluate / for the community to evaluate the magic links replacement ONLY. I would like to see an edit summary in line with the other two magic links bots, and to include a link to this BRFA. If these conditions work for you, we can move forward with a trial. SQL^{Query me!} 02:30, 8 July 2017 (UTC)

@Magioladitis: - I know this is an older BRFA and may have fallen off your radar - I meant to ping you, sorry. SQL^{Query me!} 03:11, 8 July 2017 (UTC)

@SQL: OK. How many edis do you want me to do? -- Magioladitis (talk) 06:37, 8 July 2017 (UTC)

Same as the others Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. SQL^{Query me!} 15:50, 8 July 2017 (UTC)

((BotTrialComplete)) -- Magioladitis (talk) 19:46, 8 July 2017 (UTC)

Example: [1]. -- Magioladitis (talk) 19:47, 8 July 2017 (UTC)

Diffs: [2]. There was a temporary glitch on the edit summary which was fixed. -- Magioladitis (talk) 19:50, 8 July 2017 (UTC)

Per discussions as fasr as I understand, as soon as this task gets approval I can add general fixes to the task. -- Magioladitis (talk) 19:50, 8 July 2017 (UTC)

It really worries me that you might be viewing this more about applying general fixes to as many articles as you can, than the task at hand. I was hoping we could focus on the requested task. SQL^{Query me!} 06:18, 9 July 2017 (UTC)

Just as a note, feel free to disregard Special:Diff/789668186 for the editing of whitespace - that's AWB's automatic unicode-space removal. I've run afoul of it before on a BRFA, and as near as I can tell you can't turn it off. Primefac (talk) 21:06, 8 July 2017 (UTC)

I looked at all 100 edits.

• This edit should probably not have happened. The ISBN was inside <code>...</code> tags.
• Edits like this one and this one (editing the |title= parameter within a citation template) are not desirable. It worked in this case, but it causes red Citation Style 1 errors and mangled citations in other cases. See this discussion for what can happen when a bot edits in this way.

All of the other edits looked great. Running without general fixes made the edits very easy to inspect. I agree with SQL that the bot should run without general fixes. – Jonesey95 (talk) 01:29, 9 July 2017 (UTC)

These two are very valid concerns. Is it possible to fix these? SQL^{Query me!} 06:25, 9 July 2017 (UTC)

If you're interested, Mag, I've got a working regex that will ignore an ISBN that is inside any title/publisher/date (that was a weird one) parameter of a cite template. Primefac (talk) 01:35, 9 July 2017 (UTC)

SQL I have already reported the problem of misplaced ISBNs and there are tracked. If you still think I need a regex to prevend those before happening I could use the regex of Primefac. -- Magioladitis (talk) 07:18, 9 July 2017 (UTC)

Let me know when you're ready, and we'll run another batch to make sure everything's good. My concern above regarding general fixes is still open as well. SQL^{Query me!} 07:25, 9 July 2017 (UTC)

Jonesey95 As far as I understand from the discussions so far, it is at bot owners' choice to use general fixes or not. Am I wrong? I am really asking. -- Magioladitis (talk) 07:19, 9 July 2017 (UTC)

I think, for right now it would be better to focus on the task that you've requested approval for. Let's get that 100%, then we can talk about ancillary options. SQL^{Query me!} 07:31, 9 July 2017 (UTC)

Yes, it is the bot owner's choice, but general fixes (or any other types of edits) must be part of the approved bot task. You have been told this many times. – Jonesey95 (talk) 12:42, 9 July 2017 (UTC)

Jonesey95 OK but in the discussion I raised about encouraging bot owners to add general fixes, the spirit of the opinions was that in general adding general fixes is a good thing but we can't force bot owners. I am offerring to add general fixes here. My bot trial was, as told, without general fixes. My edit summary described exactly the edit in question and even contains the replacement done. -- Magioladitis (talk) 13:04, 9 July 2017 (UTC)

Jonesey95 Ofcourse BAG can apprve this without general fixes but I wouuld find it unexpected based on the discussions so far. -- Magioladitis (talk) 13:14, 9 July 2017 (UTC)

Primefac can you please provide me the regex in question? I think you could post it in your BRFA for example. -- Magioladitis (talk) 07:28, 9 July 2017 (UTC)

Negative lookbehind to find any named param before the ISBN. (?<!(?:publisher|title|date)(?:[\s]*=[\s"]*)[^\|}]*) I suppose this could be extended to other params, but these three are the only ones I encountered (and other parameters are even less likely than "date"). Primefac (talk) 13:44, 9 July 2017 (UTC)

Primefac Thanks, I 'll start the bot trial right away. -- Magioladitis (talk) 13:51, 9 July 2017 (UTC)

Trial complete. 25 edits. -- Magioladitis (talk) 13:57, 9 July 2017 (UTC)

SQL Diffs: [3]. 25 edits with no general fixes. -- Magioladitis (talk) 14:01, 9 July 2017 (UTC)

{{BAGAssistanceNeeded}} Magioladitis (talk) 21:56, 12 July 2017 (UTC)

@Cyberpower678: since SQL is probably semi-active at this time. -- Magioladitis (talk) 07:01, 22 July 2017 (UTC)

It looks like SQL is not very active indeed so I hope he doesn't mind me taking over on this. You say the GenFixes were disabled, so I'm curious where the whitespace came from in this edit. Other than that, the edits look good.—CYBERPOWER (Chat) 13:30, 22 July 2017 (UTC)

@Cyberpower678: It was the first edit of the series. Then I turned off any additional settings I had. Now fixed. -- Magioladitis (talk) 13:38, 22 July 2017 (UTC)

Moving forward with GenFixes

The edits in the latest trial look good, so I'm doing one last trial. This trial will be with GenFixes. Here's what I want to see happen:

• You can only apply genfixes to a page if the main task of a magic link is being replaced happened on the page.
• You CANNOT make genfixes without at least replacing one magic link on the page.
• When genfixes have been performed, it should say so in the edit summary.

We will be reviewing the reliability of this task with genfixes and determine whether this task should be approved with genfixes or not.

• Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.—CYBERPOWER (Chat) 13:45, 22 July 2017 (UTC)

Cyberpower678 it's easy to check whether the main task has happened. To know whether other general fixes were applied is not straighforward. Maybe just add "and possibly other general fixes" to the edit summary? -- Magioladitis (talk) 13:48, 22 July 2017 (UTC)

If you have the original text and compare it to the version with the magic link replaced, you will easily see a change in the content to know if the genfixes should be applied. If you apply the same process to see if Genfixes made any changes to the page, to the original with magic links replaced, how would that be difficult?—CYBERPOWER (Chat) 13:51, 22 July 2017 (UTC)

Cyberpower678 How do I do this with AWB in an automatic way? It does not support page comparison in the middle of the process without the use of a custom module. If I write a custom module things will become compliacated. I have discussed with AWB fellow devs and the idea is that we don't want long edit summaries. If that does not fit your you I am OK if you approve the task without general fixes. -- Magioladitis (talk) 13:56, 22 July 2017 (UTC)

@Cyberpower678: This just isn't a supported feature in AWB. T161460 and T161467 exists however, and would greatly help with these things. The first ticket should be rather easy to address at the AWB level, but it's gone ignored by AWB devs for some reason. Headbomb {t · c · p · b} 13:57, 22 July 2017 (UTC)

This may be a stupid comment, but if you add + genfixes and there aren't genfixes, no one is going to care. It's the magic links fixing that we care about. I did that when I was cleaning out the duplicate category page list, just to cover my bases. Primefac (talk) 13:59, 22 July 2017 (UTC)

(edit conflict × 3)Ah. I'm not overly familiar with AWB. I guess it can't be helped. Then well go with Magio's suggestion of a general edit summary and move forward with the trial.—CYBERPOWER (Chat) 14:00, 22 July 2017 (UTC)

Trial complete. Only 5 pages in mainspace. -- Magioladitis (talk) 14:11, 22 July 2017 (UTC)

@Cyberpower678:: Diffs. -- Magioladitis (talk) 14:14, 22 July 2017 (UTC)

So, um, this is interesting. What are your conversion rules (i.e. why did your bot change that ISBN while mine didn't)? Primefac (talk) 14:17, 22 July 2017 (UTC)

Oh, I know - you've got it so that it edits inside of hyperlinks. That's not good. Primefac (talk) 14:18, 22 July 2017 (UTC)

There's also this, which brings me back to my original question. Primefac (talk) 14:21, 22 July 2017 (UTC)

Primefac I copied you method. Can you please post your settings file somewhere? -- Magioladitis (talk) 14:31, 22 July 2017 (UTC)

Primefac hm... now I see. I forgot to update the non-main space settings file. Just did. -- Magioladitis (talk) 14:33, 22 July 2017 (UTC)

Sure. I think you've got it so that it edits inside of elinks (I've got that option disabled) but I'm also curious about things like this. I know it has nothing to do with the passing or failing of the BRFA, mostly just wondering why yours picked it up and mine didn't. Primefac (talk) 14:35, 22 July 2017 (UTC)

Primefac Maybe you are hiding the text inside blockquotes while I don't. If you recall I have said that there seems that all bots detect the same ISBNs but in practice it turns there are slightly differences. I can investigate later. I think I had enough Wikipedia for today. Here is burning hot. -- Magioladitis (talk) 14:54, 22 July 2017 (UTC)

Aside from the elink issues, I would have liked to see more than 2 edits with actual GenFixes. Do you think you can provide me ten edits on articles only, once the elink issue is fixed?—CYBERPOWER (Chat) 15:12, 22 July 2017 (UTC)

Cyberpower678 as soon as new mainspace pages enter the tracking category. I would not like to make genfixes in talk pages because AWB provides a very limited set for talk page general fixes. Thera are no pages in mainspace right now. -- Magioladitis (talk) 15:15, 22 July 2017 (UTC)

Which is why I asked for 10 edits to article only so I can review the genfixes with the task. I only want like 10 to look at.—CYBERPOWER (Chat) 15:18, 22 July 2017 (UTC)

Cyberpower678 Diff of 25 edits. I extended my settings to catch a common mistake of using O instead of 0 in the first place. -- Magioladitis (talk) 15:39, 22 July 2017 (UTC)

The edits look good. So just as a final confirmation, did you fix the issues Primefac mentioned regarding external links?—CYBERPOWER (Around)

Yes, i did. I have two settings files. One with genfixes for mainspace and one with genfixes off. Magioladitis (talk) 19:44, 22 July 2017 (UTC)

•  Approved. I'm convinced this task will run without issue and with full compliance of bot policy.—CYBERPOWER (Around) 20:31, 22 July 2017 (UTC)

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.