Jump to content

MediaWiki talk:Gadgets-definition

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Suggesting a gadget TOC[edit]

At MediaWiki talk:Gadgets-definition/Archive 1#Add table of contents? I suggested to add a TOC to Special:Preferences#mw-prefsection-gadgets. It didn't appear practical at the time but MediaWiki makes id's at the sections now. I suggest to add this TOC to MediaWiki:Gadgets-prefstext which is displayed at top of the gadgets tab:

With a TOC like this we may be less concerned about "cluttering" the page with useful gadgets.

A version with Special:Preferences added to the links so it works here for testing:

It works for me even though it also has to switch tab. The links need updating if we change sections at MediaWiki:Gadgets-definition but that's rare. I chose a single-line TOC but it could also be multi-line. Similar code is used in MediaWiki:Pageinfo-header which adds a TOC to page information like https://en.wikipedia.org/w/index.php?title=Example&uselang=en&action=info. PrimeHunter (talk) 17:02, 25 December 2023 (UTC)[reply]

@PrimeHunter I must be confused, this is about displaying a table of contents on the page MediaWiki:Gadgets-definition correct? That page already has a TOC. — xaosflux Talk 17:17, 25 December 2023 (UTC)[reply]
@Xaosflux: No, this is about displaying a TOC at Special:Preferences#mw-prefsection-gadgets. Special pages don't have talk pages so I made the suggestion here. PrimeHunter (talk) 17:23, 25 December 2023 (UTC)[reply]
I have filed phab:T217606 already for this. Izno (talk) 17:27, 25 December 2023 (UTC)[reply]
Yes, in 2019 with no signs it's happening. The other tabs are much shorter and most wikis probably also have a short gadgets tab. I doubt MediaWiki will ever add it. If it does, we can just remove our own version. PrimeHunter (talk) 17:38, 25 December 2023 (UTC)[reply]
Shrug. I don't think it's worth doing. The list of gadgets is not so long as to be totally unwieldy. Izno (talk) 18:14, 25 December 2023 (UTC)[reply]
One related thing to note, the pref searcher works with the gadget desciptors now. — xaosflux Talk 18:34, 25 December 2023 (UTC)[reply]
I don't think that we need a phab ticket to amend MediaWiki:Gadgets-prefstext. --Redrose64 🦌 (talk) 18:37, 25 December 2023 (UTC)[reply]
We do not, which is the mechanism PrimeHunter is proposing to insert the table of contents. Izno (talk) 19:26, 25 December 2023 (UTC)[reply]
Adding to MediaWiki:Gadgets-prefstext seems fine enough to just try, put it under the big warning please. — xaosflux Talk 20:10, 25 December 2023 (UTC)[reply]
I have added the above TOC except with centering since it's displayed below a centered box.[1] PrimeHunter (talk) 17:55, 4 April 2024 (UTC)[reply]

Adding validations[edit]

Add {{#invoke:Validate gadgets|validate}} somewhere near the top.

Did you know that gadget names cannot start with a digit, or that requiresES6 flag cannot be used on a default gadget, or that a gadget name can't be more than 244 bytes, or that peer gadgets must be styles-only gadgets?

These are just a few of the checks done by Module:Validate gadgets to help avoid malformed gadget configurations. It also works on previews. (If there are no warnings, the "no issues found" message is shown only during preview.)

A demo is at testwiki:MediaWiki:Gadgets-definition (where the issues are so many that it had to be put in a collapsed box). – SD0001 (talk) 14:54, 4 January 2024 (UTC)[reply]

Added. Writ Keeper ⚇♔ 16:21, 4 January 2024 (UTC)[reply]
Very cool module. Galobtter (talk) 01:12, 5 January 2024 (UTC)[reply]
SD0001 and Writ Keeper, I admit I'm late with this concern, but I'm not too happy to see that an unprotected module had been transcluded to the central gadget definition page. Pppery template-editor-protected it four days later; I've now upgraded this to full protection. If SD0001 is interested in further editing the central gadget definition page, I think they should apply for adminship and then request interface adminship. ~ ToBeFree (talk) 18:24, 1 February 2024 (UTC)[reply]
ToBeFree: Fair enough, and I'll certainly accept a mea culpa for that, though my understanding is that its placement within the <noinclude>...</noinclude> would prevent malicious edits to the module from causing any particularly serious issues. Writ Keeper ⚇♔ 18:29, 1 February 2024 (UTC)[reply]
Thanks for the quick reply and sorry, I hadn't noticed the <noinclude>...</noinclude> – I incorrectly assumed the module only had no effect because it had no output. I just tried to build a noinclude-escaping template and a noinclude-escaping module, but neither worked; the <noinclude>...</noinclude> is probably strong enough and I'll restore the previous protection level of the module. I also take back my objection to the module being invoked on the Gadgets page as long as that remains inside noinclude tags. ~ ToBeFree (talk) 18:54, 1 February 2024 (UTC)[reply]
My understanding is that the <noinclude>...</noinclude> doesn't really do anything. Gadgets extension looks for lines starting with a * or lines that are headers and ignores everything else. However I also believe it doesn't generally consider templates, so this is probably still safe. Bawolff (talk) 19:12, 1 February 2024 (UTC)[reply]
I'm not following what the concern was? Were you worried that it was possible for a non-admin to define a new gadget by having the module emit text that looks like a gadget definition? That is not the case. MediaWiki parses the gadgets definition page as plain text and extracts the definitions. There is also no need for the <noinclude>...</noinclude> to be there. It doesn't do anything. – SD0001 (talk) 19:13, 1 February 2024 (UTC)[reply]
Yeah, that was my concern. I just did more research about "noinclude" on this type of MediaWiki pages and ended up asking in #wikimedia-tech; Bawolff had a closer look at the Gadgets extension's code and then provided the analysis above. This resolves my concern and the module is already back to template protection. Thanks all! ~ ToBeFree (talk) 19:17, 1 February 2024 (UTC)[reply]

Remove MakeMobileCollapsible gadget[edit]

Minerva has been updated to load collapsing code, example, so I believe this gadget can be removed. 🐸 Jdlrobson (talk) 02:24, 7 June 2024 (UTC)[reply]

@Izno: any concerns? — xaosflux Talk 12:17, 7 June 2024 (UTC)[reply]
Don't think so. Izno (talk) 15:32, 7 June 2024 (UTC)[reply]
 Done removed, haven't deleted the files in case there are any issues that need this back. — xaosflux Talk 15:34, 7 June 2024 (UTC)[reply]

Edit request 17 June 2024[edit]

Remove vector-2022 from the list of skins supported by responsiveContent in the Appearance section: 

responsiveContent [ResourceLoader |type=general |skins=vector, vector-2022 |peers=responsiveContentBase] |responsiveContent.js

-> 

responsiveContent [ResourceLoader |type=general |skins=vector |peers=responsiveContentBase] |responsiveContent.js

It seems not to be functioning of late, and TBH I don't know why it was enabled to begin with since it wasn't designed for the skin. See also phab:T367646.

Izno (talk) 15:51, 17 June 2024 (UTC)[reply]

Also, responsiveContentBase currently in Browsing for both Vector and Timeless probably should be living in the proximity of responsiveContent. Don't really care if that's in Appearance or Browsing. (Why do we have section names that are almost exactly the same in intent?) Izno (talk) 15:52, 17 June 2024 (UTC)[reply]
 Done It looks like when Vector 2022 was new somebody copied all Vector gadgets to Vector 2022, and nobody noticed this since. * Pppery * it has begun... 01:05, 18 June 2024 (UTC)[reply]
Retrieved from "https://en.wikipedia.org/w/index.php?title=MediaWiki_talk:Gadgets-definition&oldid=1229660802"